New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Compare Method to Class Host #599

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Varunram

Varunram commented Nov 30, 2016

Defines the cmp method on class Host with reference to #591 .

@dmiller-nmap

This comment has been minimized.

Show comment
Hide comment
@dmiller-nmap

dmiller-nmap Dec 5, 2016

@Varunram Thanks for working on this. Unfortunately, your solution was a little too complex, and I found it easier to reimplement get_id in such a way that it is stable with respect to hostname. I look forward to seeing more code contributions from you!

dmiller-nmap commented Dec 5, 2016

@Varunram Thanks for working on this. Unfortunately, your solution was a little too complex, and I found it easier to reimplement get_id in such a way that it is stable with respect to hostname. I look forward to seeing more code contributions from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment