Update Zenmap to consider the -v0 option #626
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zenmap does not consider the "-v0" option as NmapOptions.py simply uses the argument and renders multiple copies of -v. In this fix, self["-v"] has been assigned the value of -1 for the case of "-v0" because the default value for self["-v"] (when there is no option "-v" in the command itself) has been set to 0.
|
@lymanZerga11 Thanks for this! I merged it as r36534. Please let me know if you want to be credited under a different name in the CHANGELOG. |
|
Haha nice! No, this should be fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done with reference to #601. Zenmap does not consider the
-v0option asNmapOptions.pysimply uses theargand renders multiple copies of-vas @dmiller-nmap mentioned.In this fix,
self["-v"]has been assigned the value of-1for the case of-v0because,self["-v"]has been set to0(when there is no option "-v" in the command itself).render(),opt_listdoes not include "-v" ifself["-v"]is0