Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Zenmap to consider the -v0 option #626

Closed
wants to merge 1 commit into from

Conversation

@lymanZerga11
Copy link

lymanZerga11 commented Dec 26, 2016

Done with reference to #601. Zenmap does not consider the -v0 option as NmapOptions.py simply uses the arg and renders multiple copies of -v as @dmiller-nmap mentioned.

In this fix, self["-v"] has been assigned the value of -1 for the case of -v0 because,

  1. Default value for self["-v"] has been set to 0 (when there is no option "-v" in the command itself).
  2. In render() , opt_list does not include "-v" if self["-v"] is 0
jacobsunny1995
Zenmap does not consider the "-v0" option as NmapOptions.py simply uses the argument and renders multiple copies of -v. In this fix, self["-v"] has been assigned the value of -1 for the case of "-v0" because the default value for self["-v"] (when there is no option "-v" in the command itself) has been set to 0.
@dmiller-nmap
Copy link

dmiller-nmap commented Jan 11, 2017

@lymanZerga11 Thanks for this! I merged it as r36534. Please let me know if you want to be credited under a different name in the CHANGELOG.

@lymanZerga11
Copy link
Author

lymanZerga11 commented Jan 18, 2017

Haha nice! No, this should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.