-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impress remote discover #713
Conversation
…tester, and server version discovery
This is cool! I'll look closer in the morning, but here are my observations:
More feedback in the morning, I think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been a couple days and I don't have any other feedback. Just the 2 changes:
- Make the client name a script-arg, with appropriate documentation.
- Let bruteforce be any true value, not only the literal string "true"
Thanks!
Client Name is now a script-arg with the default still set to Firefox OS. The bruteforce arg no longer requires a value, just needs to be present if a user wishes it to bruteforce the PIN. Still defaults to false and checks if the user has set the script-arg explicitly to false, just in case. New example output: Thanks for the feedback Daniel! |
Sweet! I made a few cosmetic changes and committed, should show up here soon.
Also pushed a change to stdnse.lua to fix get_script_args, which wouldn't allow setting |
Script idea link:
https://secwiki.org/w/Nmap/Script_Ideas#impress-remote-discover
Example Output:
1599/tcp open libreoffice-impress-remote syn-ack LibreOffice Impress
| impress-remote-discover:
| Impress Version: 4.2.4.2
|_ Remote PIN: 1234
Version of LibreOffice Impress tested against: 4.2.4.2
https://downloadarchive.documentfoundation.org/libreoffice/old/4.2.4.2/