New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oracle-tns-version: fix connection timeout & improve error code checking #716

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@chinarulezzz

chinarulezzz commented Mar 1, 2017

  • Fixed NSE: [oracle-tns-version 192.168.1.2:1251] Couldn't get a response: TIMEOUT. This happens because Version probe length is shorter than
    announced to server.

  • Added Oracle Error Code Reference URL. It looks like this:

PORT STATE SERVICE VERSION
1521/tcp open oracle-tns Oracle TNS listener 11.2.0.3.0 (error: 1153, see http://psoug.org/oraerror/TNS-01153.htm)

  • Added a few error codes.
chinarulezzz
oracle-tns-version: fix connection timeout & improve error code checking
- Fixed `NSE: [oracle-tns-version 192.168.1.2:1251] Couldn't get a response:
TIMEOUT`. This happens because Version probe length is shorter than
announced to server.

- Added `Oracle Error Code Reference` URL. It looks like this:

PORT     STATE SERVICE    VERSION
1521/tcp open  oracle-tns Oracle TNS listener 11.2.0.3.0 (error: 1153, see http://psoug.org/oraerror/TNS-01153.htm)

- Added a few error codes.
@dmiller-nmap

This comment has been minimized.

dmiller-nmap commented Mar 2, 2017

Thanks for this fix! The parser for nmap-service-probes doesn't do octal escapes like Lua does, so the strings had different meanings from one to the other. Applying your fix now.

I don't think we'll include the link to 3rd-party documentation on errors. That kind of thing can be looked up by the user if necessary.

@nmap-bot nmap-bot closed this in b30c304 Mar 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment