oracle-tns-version: fix connection timeout & improve error code checking #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed `NSE: [oracle-tns-version 192.168.1.2:1251] Couldn't get a response: TIMEOUT`. This happens because Version probe length is shorter than announced to server. - Added `Oracle Error Code Reference` URL. It looks like this: PORT STATE SERVICE VERSION 1521/tcp open oracle-tns Oracle TNS listener 11.2.0.3.0 (error: 1153, see http://psoug.org/oraerror/TNS-01153.htm) - Added a few error codes.
|
Thanks for this fix! The parser for nmap-service-probes doesn't do octal escapes like Lua does, so the strings had different meanings from one to the other. Applying your fix now. I don't think we'll include the link to 3rd-party documentation on errors. That kind of thing can be looked up by the user if necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
NSE: [oracle-tns-version 192.168.1.2:1251] Couldn't get a response: TIMEOUT. This happens because Version probe length is shorter thanannounced to server.
Added
Oracle Error Code ReferenceURL. It looks like this:PORT STATE SERVICE VERSION
1521/tcp open oracle-tns Oracle TNS listener 11.2.0.3.0 (error: 1153, see http://psoug.org/oraerror/TNS-01153.htm)