Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
NSE for OpenWebNet discovery #915
A good start. Here are a few things to consider.
Great! These are mostly formatting changes; the protocol implementation looks fine.
This feedback is based on running the script; it still takes almost 20 seconds to run after I made some hasty fixes regarding NACK handling, but it's a big improvement over the current version.
A couple minor things and some bigger things as well. Nearly done!