Added ndmp fixes for getting info from Veritas Backup Exec Agent 15 and 16. #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
When scanning Veritas Backup Exec Agent 15 or 16 port 10000 (ndmp), both ndmp-version.nse and ndmp-fs-info.nse throw errors.
Veritas returns a NOT_AUTHORIZED_ERROR response on both these versions when doing either a get hostinfo request (which is done in ndmp-version.nse), or a get fsinfo request (done in ndmp-fs-info.nse).
This commit adds some checking for that error code in the header and some simple handling in that case. Curiously enough, it replies properly to a get serverinfo request without any authentication, so ndmp-version.nse is still useful in this case.
Here's a gist with a sanitized debug scan before the changes, which shows the errors, and after, which shows how it is now handled: https://gist.github.com/xorrbit/9b149f6074a8339fd5bcf6a467a4f557