/ nmap Public
[NSE] ldap.lua vs AD objectSID #938
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The ldap.lua NSE library currently in SVN doesn't correctly handle the Active Directory objectSID attribute. Instead it attempts to perform additional asn.1 decoding on it. Attached is a patch that implements the correct conversion from bytes to the human readable string such as
If there aren't any issues or concerns I'll commit the code later this week.
This command was tested against a Windows 2012 R2 host functioning as a Active Directory Controller. The user had Domain Admin privileges and so should be able to access all attributes.
Screen output below as well as output to CSV file. The correct objectSID,
objectSid: 1-5-21-542895397-2936746693-3965599772-500was extracted.