Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Npcap to NDIS 6.20 #167

Closed
fyodor opened this issue May 20, 2020 · 5 comments
Closed

Upgrade Npcap to NDIS 6.20 #167

fyodor opened this issue May 20, 2020 · 5 comments

Comments

@fyodor
Copy link
Member

@fyodor fyodor commented May 20, 2020

Our first step toward upgrading to the latest NDIS version is an upgrade to 6.20. This one supports all the operating systems that we currently do, and we think/home it may just need a preprocessor symbol definition to upgrade rather than any material code changes. This is a first step toward eventually supporting NDIS 6.50 for Windows 10. (I'm creating a separate issue for that part)

@fyodor
Copy link
Member Author

@fyodor fyodor commented May 21, 2020

New Update from @dmiller-nmap: Built 0.9992 with NDIS 6.20 for testing. Build is fine, but loopback capture is messed up. I've isolated the problem (unregistering WFP resources but failing to re-register when they are needed again) but will need a bit more time to make a solution. Idea I have in mind may make listing adapters faster: introduce a new state "open but not capturing" that delays some startup functions until buffer is intialized, since listing adapters results in opening every single one for a moment, but not setting a buffer size.

@guyharris
Copy link

@guyharris guyharris commented May 21, 2020

Speaking of speeding up listing adapters, see also #169.

@guyharris
Copy link

@guyharris guyharris commented May 25, 2020

Note that, with NDIS 6.20, you might have to use MediaSpecificInformationEx, rather than MediaSpecificInformation, to get the media-specific information on 802.11 adapters in monitor mode. See the NDIS_NET_BUFFER_LIST_INFO enumeration page and the NDIS_NBL_MEDIA_SPECIFIC_INFORMATION_EX structure page.

@dmiller-nmap
Copy link
Contributor

@dmiller-nmap dmiller-nmap commented May 26, 2020

Accomplished in 59a0625, but I will check on those OIDs, @guyharris. Thanks!

@dmiller-nmap
Copy link
Contributor

@dmiller-nmap dmiller-nmap commented Jun 15, 2020

Npcap 0.9993 included all changes needed to meet NDIS 6.20 compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants