Repository navigation
Npcap: Monitor mode capture dies after malformed packet delivered #404
Description
Hello,
I am experiencing an issue capturing 802.11 traffic in monitor mode using Npcap: After a seemingly arbitrary number of packets have been captured successfully (I've observed anywhere from 200 to 20000), a malformed packet will be delivered, and then no more packets will be seen until the capture is restarted.
The malformed packet appears to contain a valid radiotap header with legitimate data, but it is prefixed with other data (possibly suggesting some sort of buffer overflow). You can see in "bad.png" that there's a broadcast frame very similar to the one in "good.png", but it's 8 bytes in.
I have reproduced this problem with an Alfa AWUS036H and a Linksys WUSB600N USB adapter, on a custom built desktop and on a Surface Pro 4. On both systems, I have observed the problem using Wireshark and using a custom application that utilizes SharpPcap. Both systems are running Windows 10 with all mainline (not insider) updates applied. Both systems are running Npcap 0.94 in non-winpcap-compatible mode.
I have attached the DiagReport, install.log, and NPFInstall.log files from the desktop.
Activity
dmiller-nmap commentedon Sep 18, 2017
It looks like it might be an alignment problem. The bad packet starts with 7 bytes:
43 5f 55 55 10 3c 00. The good packet ends with a similar 7 bytes:43 5e 00 62 32 2f 00. Do you know if those ending bytes are expected? In other words, are they valid data for the good packet, or did they leak from memory somewhere, ending up at the end of the packet instead of the beginning as in the bad case?SapientGuardian commentedon Sep 18, 2017
Thanks for the reply. I'm not seeing a whole lot of similarity between those two sets of 7 bytes, and I wasn't able to find them in a similar beacon frame from the same AP. I've attached another capture, which contains three packets:
Samples.zip
dmiller-nmap commentedon Oct 18, 2017
In an effort to get better diagnostics, I have left detailed directions on #90 to run Windows Driver Verifier, which may produce a crash dump that we can debug. Please follow the directions and let us know how it works: https://github.com/nmap/nmap/issues/1036#issuecomment-337450644
SapientGuardian commentedon Oct 19, 2017
Followed the instructions, didn't get a BSOD when the malformed packet came through. Tried it a couple times just to make sure.
Fix some issues with Radiotap headers.
dmiller-nmap commentedon Oct 23, 2017
Unfortunately, I didn't find the (possible/untested) fix for this until after Npcap 0.95 was released, so you'll have to wait a bit until I can get it tested and packaged. Npcap 0.95 still has this bug.
dmiller-nmap commentedon Nov 1, 2017
Npcap 0.96 has been released, which ought to solve this issue. Please let us know so we can close this issue. https://nmap.org/npcap/
SapientGuardian commentedon Nov 1, 2017
I'm afraid this has not fixed the issue. The behavior is the same as initially reported. I can attach fresh copies of the diag/install logs if you like, but I didn't see anything too interesting in them (and they do report that the version is 0.96).
SapientGuardian commentedon Nov 11, 2017
Good news: I'm no longer able to reproduce this problem. I'm not sure what's changed in the last 10 days - maybe somehow my system was holding onto Npcap 0.95. Thanks for the fix!
dmiller-nmap commentedon Nov 13, 2017
@SapientGuardian Thanks for confirming this. Since WiFi capture works without crashing, could you do us a huge favor and report your network card, OS, and level of support on the WiFi Adapters page at SecWiki.org? If you'd rather reply here or via email, that's fine, too, and we can handle the formatting:
Thanks so much!
SapientGuardian commentedon Nov 13, 2017
Certainly. Just waiting for my account to get approved.
SapientGuardian commentedon Nov 16, 2017
@dmiller-nmap I never got account approval, so here's the data requested:
Adapter: Alfa AWUS036H
Driver: Realtek RTL8187 Wireless 802.11b/g 54Mbps USB 2.0 Network Adapter, version 6.1316.1209.2009
Windows version: Windows 10 Pro 1709 build 16299.64
Monitor mode in Wireshark: Yes
Capture works in monitor mode: Yes
No FCS errors reported: Yes (no errors)
Channel/frequency reported: No (always 0)
RSSI reported: Yes (e.g. -69dBm)
Npcap version tested: 0.96
natiya commentedon Nov 16, 2017
@SapientGuardian I'd like to check if the adapter you used is this one? Thanks!
SapientGuardian commentedon Nov 16, 2017
@natiya I don't see a version number on mine, but it looks like the picture.
natiya commentedon Nov 17, 2017
@SapientGuardian ok, thanks! Anyway, when you plug it in, doesn't have a GUI? Maybe there it says something
SapientGuardian commentedon Nov 17, 2017
No GUI, sorry.
natiya commentedon Nov 18, 2017
@SapientGuardian so how do you configure it in order to receive WiFi?
SapientGuardian commentedon Nov 18, 2017
Just the built-in Windows wifi interface that isn't specific to any adapter.
natiya commentedon Jan 5, 2018
@SapientGuardian I've tried the adapter you've got and there is Monitor Mode in Wireshark but all the packets are malformed. Are yours correctly captured? Is there anything that you installed/uninstalled such as WinPcap or something else?