-
Notifications
You must be signed in to change notification settings - Fork 544
Improve and document the way Npcap installer (particluarly silent OEM installer) handles existing installs #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I want to up-vote this about 1000 times. |
Implemented, pending testing. New decision flow, terminal states bold:
The prompt is a message box asking whether to install or quit, and the default in silent mode is always quit. "Install options" which are compared are those that alter the state of the final install, not those that change the method of installation:
|
Also implemented pending testing: TODO: Consider install directory ( |
Need to decide on meaning of
My initial thought is to implement option 2, since it allows the most possibilities:
Another possibility would be to create a modifiable installation. |
This all sounds great! I like your suggestion #1 with /force meaning always install. Even if it's the same version with the same options (maybe they are worried their install was corrupt) or even if a newer version is already on the system (maybe they always want to use the version they tested with). If that's not flexible enough, maybe we could change the name or meaning of one of the other options (or add an extra option)? |
@dmiller-nmap: Regarding this flowchart you posted before:
Is there an option combination to say "only install if there is no existing Npcap or if the existing Npcap is older or if the existing Npcap has different material install options"? So this would mean only do the downgrade part if the options differ. Keep the newer version if the options are the same. I'm not certain we need this, just wondering if it's possible with the current system? Because /downgrade=yes means always downgrade to this version even if a newer is already installed with the same material options? I do foresee customers wanting that way too. |
Ok, I think we want to enable these use cases:
Over all of this, we can layer the new "don't do unnecessary installation" behavior, which only adds 1 additional use case: "We need to uninstall and reinstall no matter what version or existing install parameters." That is the current "/force" behavior, so if we make "/downgrade" short-circuit based on install options, then that covers everything except use case 1, which I'm not sure matters anyway. |
I think no. 3 may have two cases: My understanding is that current /force behavior satisfies 3b, but what should users do for 3a? Maybe this is what you were addressing in your last paragraph but I'm not sure I fully understand. |
yes, that is what I meant. |
Ok, based on our chat today, this is the proposed new behavior:
|
These options have been added in Npcap 1.55, and the docs are updated on the website and in Npcap SDK 1.11. |
This is most relevant to Nmap OEM and its silent installer since the free/demo Npcap always runs interactively where it can ask the user what they want to do for a given install. Though our decisions here may touch upon or modify the interactive installer experience a bit too.
First let 's look at the current behavior. When the current Nmap OEM installer runs in silent mode (without other options), it always installs UNLESS a newer version of Npcap OEM is already installed. This means it re-installs if the same version of Npcap OEM is already installed, and it will also "downgrade" itself automatically from a newer version of non-OEM Npcap. If you specify /downgrade=yes, then it will also install over newer versions of the OEM version of Npcap.
While this works for many users, there are a few concerns:
What we probably want to do instead is:
The key advantages of these changes would be:
The text was updated successfully, but these errors were encountered: