Skip to content

Make Npcap and Npcap OEM installer options case insensitive #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fyodor opened this issue Sep 8, 2022 · 1 comment
Closed

Make Npcap and Npcap OEM installer options case insensitive #630

fyodor opened this issue Sep 8, 2022 · 1 comment

Comments

@fyodor
Copy link
Member

fyodor commented Sep 8, 2022

Given that the Npcap (and Npcap OEM) self-installers don't have many options, we are probably not going to ever want arguments that differ only in case. So there is probably no reason to require the "correct" case as we do now. We've manually done this for /s so it works like the canonical /S (silent install) option. But we should look for an easy way to make NSIS do this with all options.

Related issue for Nmap: nmap/nmap#2521

@fyodor
Copy link
Member Author

fyodor commented Jun 19, 2024

So we manually did this for silent-install (/S and /s) but kept this issue to ensure all other installer options are case-insensitive. But @dmiller-nmap did some testing and reports that they already are (except for /D which we can't do due to NSIS complications) and so we are happy to close this issue as complete!

@fyodor fyodor closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant