Skip to content

Npcap 1.81 does not show all-0 VLAN TCI headers for injected packets #791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmiller-nmap opened this issue Apr 22, 2025 · 1 comment
Closed

Comments

@dmiller-nmap
Copy link
Contributor

Npcap 1.81 introduced capture and injection of frames with 802.1q VLAN headers. A NET_BUFFER_LIST on the NDIS stack with an all-0 TCI value (PCP, DEI, and VID all 0) has no attribute to indicate whether it was received with such a VLAN header or not, so Npcap defaults to not including one in that case. For that reason, if a frame with such an all-0 TCI was injected via pcap_inject() or pcap_sendpacket(), it was being put in the capture queue without a VLAN header, which was not what was expected.

This issue is fixed in 454e834 by preserving any VLAN tag from injected packets that are also captured.

@dmiller-nmap
Copy link
Contributor Author

Fixed in Npcap 1.82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant