Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Npcap installer should detect and remediate for NETCFG_E_MAX_FILTER_LIMIT #83

Open
dmiller-nmap opened this issue Apr 12, 2018 · 1 comment
Labels
current enhancement

Comments

@dmiller-nmap
Copy link
Contributor

@dmiller-nmap dmiller-nmap commented Apr 12, 2018

As discussed in nmap/nmap#572, Windows 7 has a limit on the number of NDIS filter drivers that can be installed, defaulting to 8 but configurable up to 14. Right now, we detect the specific error and print a message to STDOUT in NPFInstall.exe, but the installer doesn't take any special action on this condition.

I propose 2 changes:

  1. When NETCFG_E_MAX_FILTER_LIMIT is returned, increment HKLM:\SYSTEM\CurrentControlSet\Control\Network\MaxNumFilters and try again.
  2. If the install continues to fail with the same error, fail in such a way that the executable installer can detect and display a useful error message to the user. Existing message is simply "Failed to create the npcap service for Win7, Win8 and Win10. Please try installing Npcap again, or use the latest official Npcap installer from https://nmap.org/npcap/"
@dmiller-nmap
Copy link
Contributor Author

@dmiller-nmap dmiller-nmap commented May 2, 2018

The first part of this (attempting to increment MaxNumFilters) is implemented in the installer for Npcap 0.99-r5. I would appreciate any feedback on whether this works, as I have been unable to confirm it yet.

@fyodor fyodor transferred this issue from nmap/nmap May 20, 2020
@fyodor fyodor added current enhancement labels May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current enhancement
Projects
None yet
Development

No branches or pull requests

2 participants