Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Stop looping in "consider_reading" if reading is suspended. #63
There is a bug in "consider_reading" that for filtered ssl bufferevents the loop that calls "do_read" might not terminate if data is pending (SSL_pending > 0) but reading in the bufferevent is suspended (read_suspended == 1).
This also exists in libevent 2.0.19 and 2.0.20 but not in 2.0.14 (didn't test versions between 2.0.14 and 2.0.19), so should be merged to the 2.0 fixes branch, too.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
A few answers:
If you update the branch it will reflect in this pull request. But I think you're right, it would be the most optimal before reserve_space.
Sounds good. If you guys don't mind I would like to my usual bevssl pounding in my load testing env before a merge. We've had... issues... with this code over the past year.
I'll make sure I get the tests done this week.