Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ticket26939 26943 26940 #3

Merged
merged 13 commits into from Oct 17, 2018
Merged

Ticket26939 26943 26940 #3

merged 13 commits into from Oct 17, 2018

Conversation

Reviewers

@teor2345 teor2345

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@nmathewson @teor2345
@nmathewson
Copy link
Owner

@nmathewson nmathewson commented Aug 10, 2018

Fix safety, documentation, and usize issues.
nmathewson added 12 commits Aug 9, 2018
@nmathewson
Audit and reduce occurrences of usize.
ea1f60f 
We want to use usize for counting elements in a buffer or in a
vector.  But for system parameters like "k" or "n" or the number of
counters, we use u32, for consistency across systems.

This patch is incomplete, since we need to change some APIs. I'll do
that in the next commit.
@nmathewson
Make CounterSet::new() return a Result.
c589bae 
This way it can check for parameters that would overflow u32.
@nmathewson
Stop using assert!() outside of the tests.
7234bb5 
This doesn't fix our unwrapping usage, though.
@nmathewson
Remove all non-test unwrap() calls.
e4046d9
@nmathewson
Add bounds checking for a couple of parameters
fd2c6f0
@nmathewson
Document some of math.rs
78d10bb
@nmathewson
Add doctests for FE, and improve the FE Rand implementation
d765502
@nmathewson
Docs and examples for shamir module
7d536a1 
Also, require that no TR has X coordinate of zero -- otherwise
somebody's share would be the secret value!
@nmathewson
Document the data and encrypt modules
22a08ce
@nmathewson
Document client and server module
48ef9ca
@nmathewson
Enable deny(missing_docs), and fill in the rest of the documentation
7d5a1ac
@nmathewson
Replace an older short README with a new short README
3d4b1e7
teor2345
teor2345 suggested changes Sep 21, 2018
View changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Just a few typos to fix, then we can merge.

rust/src/math.rs Outdated
// (Given a value in range 0..FE_VAL_MAX, the output is in range
// 0..FULL_BITS_MASK.)
/// Given a value in range 0..U64_MAX, returns a value in range 0..FE_VAL_MAX that
/// is equavalent modulo PRIME_ORDER.
Copy link
Contributor

@teor2345 teor2345 Sep 21, 2018

typo: equivalent

rust/src/client.rs Outdated
counter_ids: Vec<CtrId>, // XXXX use strings??
/// A map frounc couter ID to actual counter values.
Copy link
Contributor

@teor2345 teor2345 Sep 21, 2018

typo: from the?

@nmathewson
Fix two typos that teor found
9a10c01
@nmathewson nmathewson merged commit 9a10c01 into master Oct 17, 2018
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment