Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement I2CResource #118

Merged
merged 2 commits into from Nov 5, 2020
Merged

Conversation

awygle
Copy link
Contributor

@awygle awygle commented Nov 5, 2020

This PR adds an I2CResource in the same vein as SPIResource et al.

The I/O standards required for I2C do not change depending on whether the device acts as peripheral or controller, due to the ability of peripherals to stretch the clock by driving SCL. Therefore I don't bother to take in a role argument like SPIResource does.

I added the *_pullup arguments after the fashion of DirectI2CResource because the Arty A7 board file was using that construct.

I did not modify the Atlys (I2C inside of HDMI) or the Arty Z7 (I2C inside a Connector) board definitions, but did update all the other boards I found using Resource for I2C.

@awygle
Copy link
Contributor Author

awygle commented Nov 5, 2020

Per IRC discussion, removed the pullup pins. We can add them later if someone needs them.

@whitequark whitequark merged commit ec65568 into amaranth-lang:master Nov 5, 2020
@whitequark
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants