Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
I2CResource
in the same vein asSPIResource
et al.The I/O standards required for I2C do not change depending on whether the device acts as peripheral or controller, due to the ability of peripherals to stretch the clock by driving SCL. Therefore I don't bother to take in a
role
argument likeSPIResource
does.I added the
*_pullup
arguments after the fashion ofDirectI2CResource
because the Arty A7 board file was using that construct.I did not modify the Atlys (I2C inside of HDMI) or the Arty Z7 (I2C inside a Connector) board definitions, but did update all the other boards I found using
Resource
for I2C.