Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really ned to vendor golang ? #384

Closed
qinqon opened this issue Feb 4, 2020 · 1 comment
Closed

Do we really ned to vendor golang ? #384

qinqon opened this issue Feb 4, 2020 · 1 comment

Comments

@qinqon
Copy link
Member

qinqon commented Feb 4, 2020

What happened:
Now we use install-go.sh to vendor golang version from the version at go.mod

What you expected to happen:
So project is stick with the version there.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
Thing is we may not need it, since it looks like go compiler do a switch back to lang version
specified at go.mod [1] [2] [3].

Let's check if compiling failes if we add 1.13 errors Wrapf and build with golang 1.13.

[1] golang/go#30603
[2] https://golang.org/cmd/go/#hdr-The_go_mod_file
[3] golang/go#28221

Environment:

  • NodeNetworkState on affected nodes (use kubectl get nodenetworkstate <node_name> -o yaml):
  • Problematic NodeNetworkConfigurationPolicy:
  • kubernetes-nmstate image (use kubectl get pods --all-namespaces -l app=kubernetes-nmstate -o jsonpath='{.items[0].spec.containers[0].image}'):
  • NetworkManager version (use nmcli --version)
  • Kubernetes version (use kubectl version):
  • OS (e.g. from /etc/os-release):
  • Others:
@qinqon
Copy link
Member Author

qinqon commented Jul 14, 2021

we do

@qinqon qinqon closed this as completed Jul 14, 2021
qinqon pushed a commit to qinqon/kubernetes-nmstate that referenced this issue Jul 6, 2023
UPSTREAM: <carry>: OCPBUGS-11293: developing-on-ocp - update README
@kubevirt-bot kubevirt-bot mentioned this issue Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant