diff --git a/rust/src/cli/query.rs b/rust/src/cli/query.rs index 6565afcc40..99738bbfb5 100644 --- a/rust/src/cli/query.rs +++ b/rust/src/cli/query.rs @@ -66,7 +66,7 @@ pub(crate) fn sort_netstate( let mut new_iface = serde_yaml::Mapping::new(); for top_property in &IFACE_TOP_PRIORTIES { if let Some(v) = - iface.get(&Value::String(top_property.to_string())) + iface.get(Value::String(top_property.to_string())) { new_iface.insert( Value::String(top_property.to_string()), diff --git a/rust/src/lib/ifaces/inter_ifaces.rs b/rust/src/lib/ifaces/inter_ifaces.rs index d3fcff7610..accbc9d1ae 100644 --- a/rust/src/lib/ifaces/inter_ifaces.rs +++ b/rust/src/lib/ifaces/inter_ifaces.rs @@ -530,13 +530,13 @@ impl Interfaces { &mut self, ) -> Result<(), NmstateError> { let mut new_ifaces = Vec::new(); - for iface in self.kernel_ifaces.values_mut() { - if let Interface::Unknown(iface) = iface { + for iface in self.kernel_ifaces.values() { + if let Interface::Unknown(iface) = &iface { log::warn!( "Setting unknown type interface {} to ethernet", iface.base.name.as_str() ); - let iface_value = match serde_json::to_value(&iface) { + let iface_value = match serde_json::to_value(iface) { Ok(mut v) => { if let Some(v) = v.as_object_mut() { v.insert( @@ -552,8 +552,8 @@ impl Interfaces { return Err(NmstateError::new( ErrorKind::Bug, format!( - "BUG: Failed to convert {iface:?} to serde_json \ - value: {e}" + "BUG: Failed to convert {iface:?} to \ + serde_json value: {e}" ), )); } diff --git a/rust/src/lib/ifaces/loopback.rs b/rust/src/lib/ifaces/loopback.rs index 0d59aa863f..0a0d80ac6e 100644 --- a/rust/src/lib/ifaces/loopback.rs +++ b/rust/src/lib/ifaces/loopback.rs @@ -15,6 +15,7 @@ use crate::{BaseInterface, ErrorKind, InterfaceType, NmstateError}; /// * Even not desired, the `127.0.0.1/8` and `::1` are always appended to /// static IP address list. /// * Require NetworkManager 1.41+ unless in kernel only mode. +/// /// Example yaml outpuf of `[crate::NetworkState]` with loopback interface: /// ```yml /// interfaces: diff --git a/rust/src/lib/query_apply/iface.rs b/rust/src/lib/query_apply/iface.rs index 7f1654dff0..362e994fdb 100644 --- a/rust/src/lib/query_apply/iface.rs +++ b/rust/src/lib/query_apply/iface.rs @@ -34,8 +34,8 @@ impl Interface { let mut current = current.clone(); self.process_allow_extra_address(&mut current); - let self_value = serde_json::to_value(&self)?; - let current_value = serde_json::to_value(¤t)?; + let self_value = serde_json::to_value(self.clone())?; + let current_value = serde_json::to_value(current.clone())?; if let Some((reference, desire, current)) = get_json_value_difference( format!("{}.interface", self.name()),