Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nm.wired: add support to accept-all-mac-addresses #1578

Merged
merged 1 commit into from May 9, 2021

Conversation

ffmancera
Copy link
Member

This patch is introducing the accept-all-mac-addresses interface
property in Nmstate. The new property is a boolean, when True the NIC
will accept all packets.

It is supported only with NetworkManager 1.31 or greater.

Example:

---
interfaces:
- name: eth1
  type: ethernet
  state: up
  accept-all-mac-addresses: true

Signed-off-by: Fernando Fernandez Mancera ffmancera@riseup.net

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #1578 (8c8a483) into base (608840e) will decrease coverage by 27.22%.
The diff coverage is 100.00%.

❗ Current head 8c8a483 differs from pull request most recent head 05b0fd7. Consider uploading reports for the commit 05b0fd7 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             base    #1578       +/-   ##
===========================================
- Coverage   91.00%   63.77%   -27.23%     
===========================================
  Files          85       77        -8     
  Lines        6650     6071      -579     
===========================================
- Hits         6052     3872     -2180     
- Misses        598     2199     +1601     
Impacted Files Coverage Δ
libnmstate/nispor/base_iface.py 89.18% <100.00%> (-6.59%) ⬇️
libnmstate/nm/wired.py 51.61% <100.00%> (-33.95%) ⬇️
libnmstate/schema.py 97.71% <100.00%> (-2.29%) ⬇️
libnmstate/ifaces/linux_bridge_port_vlan.py 17.72% <0.00%> (-82.28%) ⬇️
nmstatectl/nmstatectl.py 0.00% <0.00%> (-78.48%) ⬇️
libnmstate/nm/bridge_port_vlan.py 27.27% <0.00%> (-72.73%) ⬇️
libnmstate/nm/ovs.py 24.32% <0.00%> (-72.44%) ⬇️
libnmstate/nm/bond.py 25.92% <0.00%> (-70.38%) ⬇️
libnmstate/ifaces/infiniband.py 25.92% <0.00%> (-70.38%) ⬇️
libnmstate/nispor/bond.py 35.00% <0.00%> (-65.00%) ⬇️
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 608840e...05b0fd7. Read the comment docs.

libnmstate/nispor/base_iface.py Outdated Show resolved Hide resolved
This patch is introducing the `accept-all-mac-addresses` interface
property in Nmstate. The new property is a boolean, when True the NIC
will accept all packets.

It is supported only with NetworkManager 1.31 or greater.

Example:

```
---
interfaces:
- name: eth1
  type: ethernet
  state: up
  accept-all-mac-addresses: true
```

Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>
@kubevirt-bot
Copy link
Collaborator

@ffmancera: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-nmstate-integ_tier1-k8s 05b0fd7 link /test pull-nmstate-integ_tier1-k8s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ffmancera ffmancera merged commit e14e91f into nmstate:base May 9, 2021
@ffmancera ffmancera deleted the acept_all_mac_addresses branch May 9, 2021 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants