add error frame handling on frame parse and connection #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morriskimani
approved these changes
Jul 22, 2021
lib/rsocket/requester.rb
Outdated
| @@ -57,6 +57,15 @@ def dispose | |||
| close_connection(true) | |||
| end | |||
|
|
|||
| # @param error_frame [RSocket:ErrorFrame] | |||
| def error_handler(error_frame) | |||
There was a problem hiding this comment.
nitpick: verb names for methods e.g. receive_response not response_receiver. In the same vein handle_error not error_handler... but we can fix in future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch to handle Error Frames