Skip to content

Commit

Permalink
test: PC-13893 Make E2E tests forward compatible (#551)
Browse files Browse the repository at this point in the history
## Motivation

`value` field of `objective` for Composite SLO is being
[deprecated](#549). Before the
update in SDK can be made, a N9 platform first needs to be
[updated](nobl9/n9#15406). To be able to release
changes in the platform, e2e tests of the latest released SDK need to
pass against it.

## Summary

E2E test assertions will pass with and without
[changes](nobl9/n9#15406) in N9 platform.

## Related changes

#551
#549
nobl9/n9#15406
nobl9/terraform-provider-nobl9#312
nobl9/terraform-provider-nobl9#295

## Testing

Run `make test/e2e` on both environments containing and not containing
nobl9/n9#15406.
  • Loading branch information
ditrytus committed Sep 23, 2024
1 parent dd7c99e commit eef86e8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tests/v1alpha_slo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -293,5 +293,8 @@ func assertV1alphaSLOsAreEqual(t *testing.T, expected, actual v1alphaSLO.SLO) {
actual.Spec.CreatedBy = ""
actual.Status = nil
actual.Spec.TimeWindows[0].Period = nil
if actual.Spec.Objectives[0].Value == nil {
actual.Spec.Objectives[0].Value = ptr(0.0)
}
assert.Equal(t, expected, actual)
}

0 comments on commit eef86e8

Please sign in to comment.