Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object context parameter #19

Merged
merged 1 commit into from
Apr 28, 2018
Merged

Add object context parameter #19

merged 1 commit into from
Apr 28, 2018

Conversation

CurlyBraceTT
Copy link
Contributor

Add object context paramter to the function calls for the complex interractions.

Consider this as a feature request, feel free to edit the code. Since object could be easily availiable for the tranformation I think it has a good usage.

Added new test as well, it should explain more.

Add object context paramter to the function calls for complex interractions
@coveralls
Copy link

coveralls commented Apr 18, 2018

Coverage Status

Coverage increased (+0.07%) to 98.907% when pulling c678a7d on CurlyBraceTT:master into 7337825 on emyann:master.

@emyann emyann self-assigned this Apr 27, 2018
@emyann
Copy link
Member

emyann commented Apr 27, 2018

Thank you for your contribution @CurlyBraceTT ! 🙏🏽 Indeed, I can easily see the use case with your Unit Test 💪🏽 . I will merge this PR by the end of the week ✌🏽

Also I would love to hear how you use Morphism ? 😃

@emyann emyann changed the base branch from master to feat/pass-current-object-computed April 28, 2018 16:20
@emyann emyann merged commit 5bd5fe0 into nobrainr:feat/pass-current-object-computed Apr 28, 2018
@emyann
Copy link
Member

emyann commented Apr 28, 2018

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@CurlyBraceTT
Copy link
Contributor Author

@emyann You are welcome! Slowly I am trying to build some game prototype with pixi and storing objects as json are very handy.

@emyann
Copy link
Member

emyann commented Apr 30, 2018

@CurlyBraceTT Awesome! Let me know if you have some questions or other ideas :) You shloud take a look to the latest version where I removed all dependencies in order to improve the package size: https://www.npmjs.com/package/morphism.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants