Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add missing argument to optionally() #2223

Merged
merged 1 commit into from Aug 20, 2021

Conversation

@limulus
Copy link
Contributor

@limulus limulus commented Aug 19, 2021

I noticed that the type for Interceptor.optionally() was missing the optional flag parameter. This PR fixes that.

gr2m
gr2m approved these changes Aug 19, 2021
@@ -198,7 +198,7 @@ declare namespace nock {
once(): this
twice(): this
thrice(): this
optionally(): this
optionally(flag?: boolean): this
Copy link
Member

@gr2m gr2m Aug 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed, it's documented as such

image

Loading

@gr2m gr2m merged commit 74e30de into nock:main Aug 20, 2021
17 checks passed
Loading
@github-actions
Copy link

@github-actions github-actions bot commented Aug 20, 2021

🎉 This PR is included in version 13.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants