Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InterceptedRequestRouter.handleWrite arity issue #2371

merged 5 commits into from Jun 15, 2022


Copy link

Hi, i found an issue with InterceptedRequestRouter.handleWrite:

Http.ClientRequest.write() can be invoked with a callback and no encoding, currently the code expected the callback to be the 3rd argument so if invoked the callback was never called.

BTW: this is my first contribution ever, so If I'm doing something wrong let me know

Copy link

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request looks great!

It looks like the coverage fell below 100% now though, could you have a look into that? After running npm test, you can run npm run test:coverage, it should show you the coverage report from ./coverage/lcov-report/index.html

Copy link

gr2m commented Jun 15, 2022

Thanks @gonza-lito! The remaining failing check is about formatting, it's not related to your changes. I'll take care of it

@gr2m gr2m changed the title fix: InterceptedRequestRouter.handleWrite arity issue fix: InterceptedRequestRouter.handleWrite arity issue Jun 15, 2022
@gr2m gr2m merged commit 7f21d0c into nock:main Jun 15, 2022
16 checks passed
Copy link

🎉 This PR is included in version 13.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants