Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentation): Add notes about Scope vs Interceptor matchHeader calls #2382

merged 2 commits into from Jul 19, 2022


Copy link

@DavidTanner DavidTanner commented Jul 18, 2022

Closes #2381
The README doesn't currently specify the difference between calling matchHeader on a Scope vs Interceptor. Following the example led to issues where the header value was overridden by subsequent calls to matchHeader on the Scope.

Copy link

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks a lot!

@gr2m gr2m merged commit d9bab65 into nock:main Jul 19, 2022
16 checks passed
Copy link

🎉 This PR is included in version 13.2.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Multiple matchHeader causes "No match for request"
2 participants