Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/2019/03/tweet-with-us.tweet #2

Merged
merged 3 commits into from
Mar 12, 2019
Merged

/2019/03/tweet-with-us.tweet #2

merged 3 commits into from
Mar 12, 2019

Conversation

gr2m
Copy link
Member

@gr2m gr2m commented Mar 6, 2019

No description provided.

@RichardLitt
Copy link
Member

Not sure what "Have something interesting for nock community? " means. Maybe add a 'Have something interesting to say to the nock community?'?

@gr2m
Copy link
Member Author

gr2m commented Mar 7, 2019

yeah ... maybe at this point, we should define what is interesting? I’d say

  • interesting usage of nock
  • everything about http mocking, beyond just nock
  • interesting use cases of nock

anything else?

@RichardLitt
Copy link
Member

  • Items relevant to the Nock community
  • Code related comments in regards to nock (refactors, TODOs, and so on)

@paulmelnikow
Copy link
Member

Wow, the previews right in the PR? This is freakin' amazing!

@@ -0,0 +1,2 @@
Have something interesting for nock community? Submit a tweet on GitHub:
https://github.com/nock/twitter/tree/master/tweets#readme
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so maybe we should just link to the repository and improve its README there?

We have a private WIP twitter repo for Probot, the READMe looks like this

image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make sense for me. But we can have multiple tweets. It's not a problem to do so, right?

Can twitterbot make threads?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, but something I’d love to add support for in future

RichardLitt added a commit that referenced this pull request Mar 10, 2019
docs: Add note about what is accepted (#2), license
@paulmelnikow
Copy link
Member

One I'd add:

  • Node testing philosophy and strategy

@gr2m
Copy link
Member Author

gr2m commented Mar 11, 2019

This is ready to go, I’d tweet it tomorrow morning pacific time unless anyone objects?

@RichardLitt
Copy link
Member

RichardLitt commented Mar 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants