Fix: update data overwrites the insert data in grid

[DarkPhoenix2704]

Change Summary

Created At and CreatedBy info getting lost in grid when the record is updated while getting saved

Closes #9490

Change type

• fix: (bug fix for the user, not a fix to a build script)

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request focuses on modifications to the useInfiniteData composable in the packages/nc-gui/composables/useInfiniteData.ts file. The changes primarily affect the insertRow and updateRowProperty functions, enhancing the handling of row data during insertion and updates. The modifications ensure that the state of rows in the cache remains consistent with the performed operations, addressing potential issues with row management in the application.

Changes

File	Change Summary
packages/nc-gui/composables/useInfiniteData.ts	- Updated insertRow function to populate row and oldRow with insertedData - Modified rowMeta to explicitly set rowIndex - Adjusted updateRowProperty function to handle row references more accurately - Updated function signatures for both methods

Assessment against linked issues

Objective	Addressed	Explanation
Add records in Grid view for external databases [#9490]	❓	Partial changes suggest addressing row insertion, but full resolution requires further investigation

Possibly related PRs

• fix: Error in Grid when pageInfo is undefined in list api #10133: Modifications to loadData function in useInfiniteData.ts with error handling improvements
• fix(nc-gui): new record visibility issue in new table #10139: Updates to loadData function focusing on null safety for pageInfo

Suggested labels

🐛 Type: Bug, size:M, lgtm

Suggested reviewers

• pranavxc
• mertmit

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/nc-gui/composables/useInfiniteData.ts (1)

986-989: Initialize cachedRow to prevent potential undefined usage.
Declaring let cachedRow: Row then assigning in a later block might cause confusion or potential runtime errors if flow changes in the future. Although the code flow ensures it's assigned before usage, explicitly initializing could improve clarity.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02cdcc0 and 908d93b.

📒 Files selected for processing (1)

• packages/nc-gui/composables/useInfiniteData.ts (3 hunks)

🔇 Additional comments (2)

packages/nc-gui/composables/useInfiniteData.ts (2)

841-847: Confirm merged data order when inserting rows.
Here, row: { ...insertedData, ...currentRow.row } places any existing properties in currentRow.row last, meaning they override server-returned insertedData if there's a conflict. This is likely correct for preserving unsaved changes, but if you want server-derived properties like "CreatedAt"/"CreatedBy" to take precedence, consider reversing the spread order or removing the second spread altogether if it’s unintended.

---

999-1009: Ensure old metadata is retained during property updates.
Merging (cachedRow || row) with additional updates preserves any prior metadata like "CreatedBy" or "CreatedAt." This behavior matches the PR's goal of preventing overwrites that discard metadata during updates. The code looks good, but be sure to confirm all calling code uses the updated approach consistently.

[github-actions]

Uffizzi Preview deployment-59385 was deleted.