Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nc-gui): use default limit from app info if specified #3622

Merged
merged 6 commits into from Sep 24, 2022

Conversation

wingkwong
Copy link
Member

Change Summary

ref: #3617

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Example: DB_QUERY_LIMIT_DEFAULT=73

image

packages/nc-gui/composables/useSharedView.ts Outdated Show resolved Hide resolved
packages/nc-gui/composables/useSharedView.ts Outdated Show resolved Hide resolved
packages/nc-gui/composables/useViewData.ts Outdated Show resolved Hide resolved
packages/nc-gui/composables/useViewData.ts Outdated Show resolved Hide resolved
@o1lab o1lab removed the request for review from mustafapc19 September 14, 2022 11:35
@wingkwong wingkwong modified the milestone: 🎯 0.98 Sep 24, 2022
@wingkwong wingkwong merged commit 6c4e29e into develop Sep 24, 2022
@wingkwong wingkwong deleted the fix/default-limit branch September 24, 2022 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants