-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(nc-gui): dark mode styles for longtext field in form view #4099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dark mode styles for long text is ok.
Some other issues I've noticed while testing in this PR.
- I think it's better to extend the width. In dark mode, I know where I should click. However, in light mode, if I click rightmost area, the input is not focused.
- In the thank-you page, keep press enter and you will see
Saved successfully. And it is considered saving a new form. (i.e. click N times. N new records will be inserted)
|
Ah thanks for pointing that put, I'll correct that :) |
fcba101 to
c7b243a
Compare
4a44c26 to
017a451
Compare
017a451 to
4f5a4a6
Compare
|
@wingkwong Issues are fixed |
wingkwong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcakmakoglu The second one is still reproducible. I think some changes may be done here.
| onKeyStroke(['Enter', 'Space'], () => { |
Besides, I think it's better to set a upper bound.
|
@wingkwong Whoops i forgot to exchange the submit fn ^^ Also set an upper limit of 5s for transitions. |
wingkwong
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good.



Change Summary
Change type
Test/ Verification
Provide summary of changes.
Additional information / screenshots (optional)
Anything for maintainers to be made aware of