Skip to content

Conversation

@bcakmakoglu
Copy link
Contributor

@bcakmakoglu bcakmakoglu commented Oct 14, 2022

Change Summary

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

Provide summary of changes.

Additional information / screenshots (optional)

Anything for maintainers to be made aware of

@bcakmakoglu bcakmakoglu added the 🐛 Type: Bug Something is broken or incorrect unexpectedly. label Oct 14, 2022
@bcakmakoglu bcakmakoglu self-assigned this Oct 14, 2022
@bcakmakoglu bcakmakoglu linked an issue Oct 14, 2022 that may be closed by this pull request
1 task
@bcakmakoglu bcakmakoglu added the 👓 Scope : View Related to views label Oct 14, 2022
Copy link
Contributor

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dark mode styles for long text is ok.

Some other issues I've noticed while testing in this PR.

  1. I think it's better to extend the width. In dark mode, I know where I should click. However, in light mode, if I click rightmost area, the input is not focused.

image

  1. In the thank-you page, keep press enter and you will see Saved successfully. And it is considered saving a new form. (i.e. click N times. N new records will be inserted)

image

@bcakmakoglu
Copy link
Contributor Author

Ah thanks for pointing that put, I'll correct that :)

@bcakmakoglu
Copy link
Contributor Author

@wingkwong Issues are fixed

Copy link
Contributor

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bcakmakoglu The second one is still reproducible. I think some changes may be done here.

onKeyStroke(['Enter', 'Space'], () => {

Besides, I think it's better to set a upper bound.

image

@bcakmakoglu
Copy link
Contributor Author

@wingkwong Whoops i forgot to exchange the submit fn ^^
Should be fine now.

Also set an upper limit of 5s for transitions.

Copy link
Contributor

@wingkwong wingkwong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good.

@bcakmakoglu bcakmakoglu merged commit ef96178 into develop Oct 26, 2022
@bcakmakoglu bcakmakoglu deleted the fix/dark-mode-survey branch October 26, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👓 Scope : View Related to views 🐛 Type: Bug Something is broken or incorrect unexpectedly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants