Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nocodb): handle type in round function in postgres #4239

Merged
merged 1 commit into from Nov 1, 2022

Conversation

wingkwong
Copy link
Member

@wingkwong wingkwong commented Oct 30, 2022

Change Summary

cast numeric in the first parameter in round function (PG only).

ref: #4232

Change type

  • feat: (new feature for the user, not a new feature for build script)
  • fix: (bug fix for the user, not a fix to a build script)
  • docs: (changes to the documentation)
  • style: (formatting, missing semi colons, etc; no production code change)
  • refactor: (refactoring production code, eg. renaming a variable)
  • test: (adding missing tests, refactoring tests; no production code change)
  • chore: (updating grunt tasks etc; no production code change)

Test/ Verification

with precision 3.

image

without precision.
image

@mertmit mertmit merged commit b70b270 into develop Nov 1, 2022
@mertmit mertmit deleted the fix/round-formula-pg branch November 1, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants