Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved refresh sidebar logic #4545

Merged
merged 1 commit into from Nov 30, 2022
Merged

fix: improved refresh sidebar logic #4545

merged 1 commit into from Nov 30, 2022

Conversation

mertmit
Copy link
Member

@mertmit mertmit commented Nov 30, 2022

Change Summary

Re #4529

  • Refresh sidebar only if next view doesn't have sidebar

Change type

  • fix: (bug fix for the user, not a fix to a build script)

@mertmit
fix: improved refresh sidebar logic
3a54b96 
Signed-off-by: mertmit <mertmit99@gmail.com>
@dstala
Copy link
Member

dstala commented Nov 30, 2022

tried few times; looked good. will continue to be on this branch. lets see if we see this issue.

@dstala dstala merged commit 260a188 into develop Nov 30, 2022
@dstala dstala deleted the fix/sidebar-refresh branch November 30, 2022 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavxc pranavxc pranavxc approved these changes

@dstala dstala dstala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mertmit @dstala @pranavxc