Skip to content

Nc fix(nc-gui): form redirect url issue #9612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Nc fix(nc-gui): form redirect url issue #9612

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c83e66
fix(nc-gui): form redirect url issue
rameshmane7218 Oct 8, 2024
1b31dfc
fix(nc-gui): reload page after adding form redirect url in pushState
rameshmane7218 Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions packages/nc-gui/composables/useSharedFormViewStore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,24 @@ const [useProvideSharedFormStore, useSharedFormStore] = useInjectionState((share
const pk = extractPkFromRow(newRecord, meta.value?.columns as ColumnType[])

if (pk && isValidRedirectUrl.value) {
const url = sharedFormView.value!.redirect_url!.replace('{record_id}', pk)
window.location.href = url
window.location.reload()
const redirectUrl = sharedFormView.value!.redirect_url!.replace('{record_id}', pk)

// Create an anchor element to parse the URL
const anchor = document.createElement('a')
anchor.href = redirectUrl

// Check if the redirect URL has the same host as the current page
const isSameHost = anchor.host === window.location.host

if (isSameHost) {
// Use pushState for internal links
window.history.pushState({}, 'Redirect', redirectUrl)
// Reload the page
window.location.reload()
} else {
// For external links, use window.location.href
window.location.href = redirectUrl
}
} else {
submitted.value = true
progress.value = false
Expand Down
Loading