fix: show self referencing belongs to

[lusimeon]

closes: #8958

Change Summary

Change visibility of self referencing belongs to in ui, see #8958.

Change type

• fix: (bug fix for the user, not a fix to a build script)

Test/ Verification

1. Create a self referencing "Links" column (with "Has Many" relation type).
2. Two columns should be created and displayed on ui, one for the has-many side, another for the belongs-to side of the relation.

Additional information

According to previously implemented code comment, self referencing belongs to were purposely hidden from ui, but i don't figure out why, any idea?

[coderabbitai]

📝 Walkthrough

📝 Walkthrough

Walkthrough

The changes in this pull request focus on simplifying the logic for determining the system property in the createHmAndBtColumn and createOOColumn functions within the columnHelpers.ts file. The previous conditions for setting the system property based on parent and child IDs have been removed, relying solely on the isSystemCol parameter. Additionally, there are refinements in handling the meta object, specifically the removal of the bt flag before inserting the hm column. Validation functions remain unchanged in their core logic.

Changes

File Path	Change Summary
packages/nocodb/src/helpers/columnHelpers.ts	Simplified system property logic in createHmAndBtColumn and createOOColumn. Refined meta object handling by removing bt flag before inserting hm column. Minor adjustments in comments and formatting.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure linked records are visible without reloading (#[8940])	❌	The changes do not address the modal display issue directly.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 71ce1bf and 93751ed.

📒 Files selected for processing (1)

• packages/nocodb/src/helpers/columnHelpers.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/nocodb/src/helpers/columnHelpers.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lusimeon]

Closed due to #8958 (comment)