From 1ea21d1acf22b090126eb3d297b875f9072dfefe Mon Sep 17 00:00:00 2001 From: Scott Todd Date: Fri, 14 Jun 2024 19:55:10 -0700 Subject: [PATCH] Fix hip dynamic_symbols_test to check min version. (#17674) Progress on https://github.com/iree-org/iree/issues/17370 ci-exactly: build_all, test_amd_mi250 --- runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc b/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc index fe64ab9dfa4f..87f075e83cfe 100644 --- a/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc +++ b/runtime/src/iree/hal/drivers/hip/dynamic_symbols_test.cc @@ -87,9 +87,11 @@ TEST(NCCLDynamicSymbolsTest, CreateFromSystemLoader) { GTEST_SKIP() << "HIP RCCL symbols cannot be loaded, skipping test."; } + // Check that the loaded version is at least the version we compiled for. int nccl_version = 0; NCCL_CHECK_ERRORS(nccl_symbols.ncclGetVersion(&nccl_version)); - ASSERT_EQ(NCCL_VERSION_CODE, nccl_version); + ASSERT_GE(nccl_version, NCCL_VERSION_CODE); + iree_hal_hip_nccl_dynamic_symbols_deinitialize(&nccl_symbols); iree_hal_hip_dynamic_symbols_deinitialize(&hip_symbols); }