New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodaTime 2.2.2 NuGet package appears to be built "non-optimized" #1027

Closed
jdaigle opened this Issue Nov 15, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@jdaigle

jdaigle commented Nov 15, 2017

After upgrading to the NodaTime 2.2.2 NuGet package, our BenchmarkDotNet tests fail with the following error:

// Validating benchmarks:
Assembly Foo which defines benchmarks references non-optimized NodaTime

Reverting to any previous version works.

@jskeet

This comment has been minimized.

Member

jskeet commented Nov 15, 2017

Thanks for reporting this. I'll look into it as soon as I can. It may be a problem with the build scripts used when there's a new version of TZDB. (If that's the case, it'll mean rebuilding 2.1.1 and 2.0.4 as well...)

@jskeet jskeet self-assigned this Nov 15, 2017

@jskeet

This comment has been minimized.

Member

jskeet commented Nov 15, 2017

Confirmed it's the debug build, by looking in ildasm - if NodaTime.Utility.DebugPreconditionException exists, it's the debug build.

It looks like the 1.x releases are okay, fortunately.

@jskeet jskeet added bug build labels Nov 15, 2017

@jskeet

This comment has been minimized.

Member

jskeet commented Nov 15, 2017

Right, found the problem. It's easy to fix in the update scripts, but it'll need a little care when doing the releases, to get appropriate commit messages.

jskeet added a commit to jskeet/nodatime that referenced this issue Nov 15, 2017

@jskeet jskeet closed this in #1030 Nov 15, 2017

jskeet added a commit that referenced this issue Nov 15, 2017

@jskeet

This comment has been minimized.

Member

jskeet commented Nov 16, 2017

All the new packages have now been pushed - if you update to latest, it should fix the problem. Obviously if it doesn't, please shout!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment