Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming DateTimeZone.GetOffsetFromUtc to GetUtcOffset #121

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 4 comments
Closed
Labels
bug
Milestone

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

DateTimeZone.GetOffsetFromUtc is conceptually equivalent to the BCL 
TimeZoneInfo.GetUtcOffset. There's no particular *reason* for the names to 
differ, and the existing Noda Time one isn't desperately better than the BCL 
name.

We should work out what we're going to do and do it before v1. (It'll be pretty 
simple to do if we want to, but it must be done before v1.)

Original issue reported on code.google.com by jonathan.skeet on 19 Oct 2012 at 9:22

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

LGTM, fwiw.

Original comment by malcolm.rowe on 20 Oct 2012 at 9:36

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Great - will do that later then.

Original comment by jonathan.skeet on 20 Oct 2012 at 9:41

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 313b6f74e73d.

Original comment by jonathan.skeet on 20 Oct 2012 at 7:49

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 10 Nov 2012 at 10:20

  • Added labels: Milestone-1.0.0
  • Removed labels: Milestone-1.0
@malcolmr malcolmr added the bug label Mar 15, 2015
@malcolmr malcolmr modified the milestone: 1.0.0 Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants