Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping TZDB updates for 1.x #1243

Closed
jskeet opened this issue Dec 30, 2018 · 2 comments
Closed

Consider dropping TZDB updates for 1.x #1243

jskeet opened this issue Dec 30, 2018 · 2 comments
Assignees

Comments

@jskeet
Copy link
Member

@jskeet jskeet commented Dec 30, 2018

Using nuget.org for metrics, 1.x is hardly used nowadays. We probably don't need to keep it up to date with TZDB.

It would be reasonable to keep it supported in terms of any significant bugs found in it, but that's all I suggest we do.
(I'm about to release 2018h in 1.4.x, but this may be the last one. And it's possible that I may not even do that if it proves tricky on my new machine...)

@jskeet jskeet self-assigned this Dec 30, 2018
@jskeet
Copy link
Member Author

@jskeet jskeet commented Dec 30, 2018

It looks like this is actually relatively hard to achieve - even finding the .NET 3.5 SDK (let alone the client profile and PCL profiles) is tricky.
It may be time to retire the 1.x line.

For the moment I'm just releasing 2.4.3 for 2018h. We can create a 1.4.x with 2018h in if discussion here suggests it's worthwhile.

jskeet added a commit to jskeet/nodatime that referenced this issue Dec 30, 2018
Additional changes:

- Drop updates of 2.3.x for TZDB
- For now, drop updates of 1.4.x for TZDB. (We may want to revisit this. See nodatime#1243.)
- Update a test which was rendered invalid by the data changing
jskeet added a commit that referenced this issue Dec 30, 2018
Additional changes:

- Drop updates of 2.3.x for TZDB
- For now, drop updates of 1.4.x for TZDB. (We may want to revisit this. See #1243.)
- Update a test which was rendered invalid by the data changing
@jskeet
Copy link
Member Author

@jskeet jskeet commented Mar 26, 2019

Version 1.4.7, released on 2018-10-28, now has 1968 downloads, according to nuget.org.
Version 2.4.2 was released on the same date but superseded on 2018-12-30 - and had 262,908 downloads.

That makes it pretty obvious that it's not worth going to extraordinary lengths to support 1.x.

I'm adjusting the documentation accordingly, and closing this issue.

@jskeet jskeet closed this Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant