New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern factory method naming inconsistency #137

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015

We have CreateWithCurrentCulture() (and WithCulture()), but then 
CreateWithInvariantInfo().

Why is the latter not CreateWithInvariantCulture()?

Original issue reported on code.google.com by malcolm.rowe on 2 Nov 2012 at 9:41

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Well yes, they're inconsistent *now*, as NodaFormatInfo is internal, so all the 
public-facing methods taking a NodaFormatInfo have gone. They were fine when we 
were encouraging users to think in terms of NodaFormatInfo, with CultureInfo 
being just a way of getting a NodaFormatInfo.

In other words, CreateWithInvariantInfo was equivalent to Create(..., 
NodaFormatInfo.InvariantInfo) rather than Create(..., 
CultureInfo.InvariantCulture).

Given the current state, it would make sense to use CreateWithInvariantCulture 
though. Will fix that up.

Original comment by jonathan.skeet on 3 Nov 2012 at 7:48

GoogleCodeExporter commented Mar 15, 2015

Well yes, they're inconsistent *now*, as NodaFormatInfo is internal, so all the 
public-facing methods taking a NodaFormatInfo have gone. They were fine when we 
were encouraging users to think in terms of NodaFormatInfo, with CultureInfo 
being just a way of getting a NodaFormatInfo.

In other words, CreateWithInvariantInfo was equivalent to Create(..., 
NodaFormatInfo.InvariantInfo) rather than Create(..., 
CultureInfo.InvariantCulture).

Given the current state, it would make sense to use CreateWithInvariantCulture 
though. Will fix that up.

Original comment by jonathan.skeet on 3 Nov 2012 at 7:48

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Fixed in both default and 1.0.x branches.

Original comment by jonathan.skeet on 3 Nov 2012 at 7:58

GoogleCodeExporter commented Mar 15, 2015

Fixed in both default and 1.0.x branches.

Original comment by jonathan.skeet on 3 Nov 2012 at 7:58

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Original comment by jonathan.skeet on 3 Nov 2012 at 7:59

  • Changed state: Fixed

GoogleCodeExporter commented Mar 15, 2015

Original comment by jonathan.skeet on 3 Nov 2012 at 7:59

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

This issue was closed by revision 2b130ebf697a.

Original comment by jonathan.skeet on 3 Nov 2012 at 8:33

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 2b130ebf697a.

Original comment by jonathan.skeet on 3 Nov 2012 at 8:33

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

This issue was closed by revision 25781249578d.

Original comment by jonathan.skeet on 3 Nov 2012 at 8:33

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 25781249578d.

Original comment by jonathan.skeet on 3 Nov 2012 at 8:33

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Original comment by malcolm.rowe on 10 Nov 2012 at 10:20

  • Added labels: Milestone-1.0.0
  • Removed labels: Milestone-1.0

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 10 Nov 2012 at 10:20

  • Added labels: Milestone-1.0.0
  • Removed labels: Milestone-1.0

@malcolmr malcolmr added the bug label Mar 15, 2015

@malcolmr malcolmr modified the milestone: 1.0.0 Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment