Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for XML Schema Definition #1496

Closed
0xced opened this issue Mar 23, 2020 · 4 comments
Closed

Support for XML Schema Definition #1496

0xced opened this issue Mar 23, 2020 · 4 comments
Assignees
Milestone

Comments

@0xced
Copy link
Contributor

@0xced 0xced commented Mar 23, 2020

Are you planing to release version 3.0 soon? I have been working on adding support for XML Schema Definition in NodaTime and I think it would be a good feature to have in version 3.

The pull request is almost ready, sneak peek: https://github.com/0xced/nodatime/tree/XmlSchemaDefinition

@jskeet
Copy link
Member

@jskeet jskeet commented Mar 23, 2020

I was hoping to - recent events have somewhat changed my ability to plan anything.

Some options:

  • I release 3.0, and you rebase to that, getting the change into 3.1
  • I wait and merge the change, then release 3.0
  • I wait and merge the change, then release another beta

I'm tempted to go for the last option, but I'm interested in your opinion.

If you could make it clear what impact this has, that would be really useful :)

@jskeet jskeet self-assigned this Mar 23, 2020
@jskeet jskeet added this to the 3.0 milestone Mar 23, 2020
@jskeet jskeet removed this from the 3.0 milestone Mar 23, 2020
@jskeet jskeet added this to the 3.0-consider milestone Mar 23, 2020
@0xced
Copy link
Contributor Author

@0xced 0xced commented Apr 7, 2020

I would love to see it in 3.0. The pull request is up in #1500. Let's continue the discussion in the pull request.

@0xced 0xced closed this as completed Apr 7, 2020
@jskeet jskeet reopened this Apr 7, 2020
@jskeet
Copy link
Member

@jskeet jskeet commented Apr 7, 2020

Reopening to leave this as the feature request that's hopefully implemented by the PR.

@jskeet
Copy link
Member

@jskeet jskeet commented Apr 19, 2020

Closing now as it's implemented.

@jskeet jskeet closed this as completed Apr 19, 2020
@malcolmr malcolmr removed this from the 3.0-consider milestone May 21, 2020
@malcolmr malcolmr added this to the 3.0 milestone May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants