Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check handling of time of 24:00 #153

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Closed

Check handling of time of 24:00 #153

GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Labels
bug
Milestone

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

This SO question:

http://stackoverflow.com/questions/13527292

led me to consider whether we can parse date/times such as

2012-11-23T24:00:00

which is permitted by ISO-8601 and should be equivalent to

2012-11-24T00:00:00

Original issue reported on code.google.com by jonathan.skeet on 23 Nov 2012 at 10:43

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Nope, looks like we don't handle it.

We probably need to parse an hour-of-day of 24, and then special-case it later 
- it should only be valid with zero values for everything less.

Original comment by jonathan.skeet on 24 Nov 2012 at 8:27

  • Changed state: Started
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision f7ac0365d8ca.

Original comment by jonathan.skeet on 24 Nov 2012 at 11:54

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 6 Apr 2013 at 9:08

  • Added labels: Milestone-1.1.0
@malcolmr malcolmr added the bug label Mar 15, 2015
@malcolmr malcolmr modified the milestone: 1.1.0 Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants