Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YearMonth should have a TypeConverter #1539

Closed
malcolmr opened this issue May 21, 2020 · 1 comment · Fixed by #1541
Closed

YearMonth should have a TypeConverter #1539

malcolmr opened this issue May 21, 2020 · 1 comment · Fixed by #1541
Assignees
Milestone

Comments

@malcolmr
Copy link
Contributor

I'm looking at the changes between 2.3 and 3.0-beta, and one such is #1237, in which we added TypeConverter support for all public types, using ISO patterns or otherwise.

We later added YearMonth, but we didn't go back and add a TypeConverter for YearMonth, even though YearMonthPattern.Iso exists.

Should we? (and should we for 3.0?)

@malcolmr malcolmr added this to the 3.0 milestone May 21, 2020
@jskeet
Copy link
Member

jskeet commented May 21, 2020

Good question. I think it's probably simple enough to be worth doing for 3.0.

@jskeet jskeet self-assigned this May 21, 2020
jskeet added a commit to jskeet/nodatime that referenced this issue May 21, 2020
(Like the other converters, this only handles the ISO calendar system.)

Fixes nodatime#1539.
jskeet added a commit that referenced this issue May 21, 2020
(Like the other converters, this only handles the ISO calendar system.)

Fixes #1539.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants