New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more utility methods and types for time zones #172

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 6 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015

It can be useful to determine whether two time zones are equivalent over some 
interval, within certain criteria (e.g. you may or may not care about names, 
and you may or may not want to distinguish between "standard + DST" and "wall 
offset").

Likewise it can also be useful to create a sequence of ZoneIntervals and 
transition points within a certain interval.

These are not *too* hard to do correctly, but there are a few corner cases to 
get right. It would be nice to supply them ourselves.

(Having a DateTimeZoneEqualityComparer would also allow for better 
serialization tests...)

Original issue reported on code.google.com by jonathan.skeet on 17 Jan 2013 at 9:45

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

Revision 6347cc315cea and revision acf149cdf074 each provide at least part of 
what we want here - possibly all of it. API needs reviewing before making it 
public though.

Original comment by jonathan.skeet on 20 Jan 2013 at 9:18

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

When you say "making it public", you mean "releasing 1.1", right? :-)  The 
classes and suchlike are public anyway.

Original comment by malcolm.rowe on 20 Jan 2013 at 9:20

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

ZoneEqualityComparer is currently an internal class. Looks like I made 
GetAllZoneIntervals public when I meant it to be internal. The point of making 
them internal would be to not gate the 1.1 release on getting them into a 
shippable state... although I strongly suspect we will be able to anyway; 
especially GetAllZoneIntervals which is pretty simple.

Original comment by jonathan.skeet on 20 Jan 2013 at 9:22

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 25 Jan 2013 at 9:24

  • Added labels: Type-Enhancement, Milestone-1.1-consider
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

This is implemented, and will be reviewed as part of issue 173.

Original comment by jonathan.skeet on 21 Mar 2013 at 2:50

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 6 Apr 2013 at 9:08

  • Added labels: Milestone-1.1.0
  • Removed labels: Milestone-1.1-consider

@malcolmr malcolmr modified the milestone: 1.1.0 Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment