New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZoneYearOffset fails subtly for Next/Previous with a time of 24:00 #174

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015

Still trying to work out how to best reproduce this simply, but I've seen an 
exception (repeatably) fetching Asia/Amman. I suspect our caching is slightly 
broken.

Will work up a full repro; will then check whether 1.0.1 is broken too.

Original issue reported on code.google.com by jonathan.skeet on 21 Jan 2013 at 9:06

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Okay, this turned out to be a bug in ZoneYearOffset, only for years with a 
transition time of "24:00" - which only affects Asia/Amman (and any aliases). 
Asking for the previous transition could occasionally return a *later* instant.

The fix for this simplifies ZoneYearOffset somewhat... which makes me slightly 
nervous. It looks like this changes Tzdb.nzd slightly as well; I'll need to 
validate that this is simply changes to the transitions in Amman, to make them 
correct.

Original comment by jonathan.skeet on 21 Jan 2013 at 7:54

GoogleCodeExporter commented Mar 15, 2015

Okay, this turned out to be a bug in ZoneYearOffset, only for years with a 
transition time of "24:00" - which only affects Asia/Amman (and any aliases). 
Asking for the previous transition could occasionally return a *later* instant.

The fix for this simplifies ZoneYearOffset somewhat... which makes me slightly 
nervous. It looks like this changes Tzdb.nzd slightly as well; I'll need to 
validate that this is simply changes to the transitions in Amman, to make them 
correct.

Original comment by jonathan.skeet on 21 Jan 2013 at 7:54

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Oh, and once we've fixed this we should consider a 1.0.2 bug fix release.

Original comment by jonathan.skeet on 21 Jan 2013 at 7:55

  • Changed title: ZoneYearOffset fails subtly for Next/Previous with a time of 24:00

GoogleCodeExporter commented Mar 15, 2015

Oh, and once we've fixed this we should consider a 1.0.2 bug fix release.

Original comment by jonathan.skeet on 21 Jan 2013 at 7:55

  • Changed title: ZoneYearOffset fails subtly for Next/Previous with a time of 24:00
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

False alarm about the change to Tzdb.nzd -  I built against the wrong data. 
Rebuilding with the right data gives identical output to the previous version.

Committing this to the 1.1 branch, but would appreciate extra eyes on it to 
check that it's sane.

Original comment by jonathan.skeet on 21 Jan 2013 at 8:21

GoogleCodeExporter commented Mar 15, 2015

False alarm about the change to Tzdb.nzd -  I built against the wrong data. 
Rebuilding with the right data gives identical output to the previous version.

Committing this to the 1.1 branch, but would appreciate extra eyes on it to 
check that it's sane.

Original comment by jonathan.skeet on 21 Jan 2013 at 8:21

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

This issue was closed by revision e217a98bf354.

Original comment by jonathan.skeet on 21 Jan 2013 at 8:23

  • Changed state: Fixed

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision e217a98bf354.

Original comment by jonathan.skeet on 21 Jan 2013 at 8:23

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

This issue was closed by revision 5f5d0a400934.

Original comment by jonathan.skeet on 23 Jan 2013 at 8:43

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 5f5d0a400934.

Original comment by jonathan.skeet on 23 Jan 2013 at 8:43

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

(The second comment here is having applied the change to the 1.0.x branch, as 
if we *do* make another 1.0 release, we'd want it in there.)

Original comment by jonathan.skeet on 23 Jan 2013 at 8:46

GoogleCodeExporter commented Mar 15, 2015

(The second comment here is having applied the change to the 1.0.x branch, as 
if we *do* make another 1.0 release, we'd want it in there.)

Original comment by jonathan.skeet on 23 Jan 2013 at 8:46

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Original comment by malcolm.rowe on 30 Jan 2013 at 11:18

  • Added labels: Milestone-1.1.0

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 30 Jan 2013 at 11:18

  • Added labels: Milestone-1.1.0

@malcolmr malcolmr added the bug label Mar 15, 2015

@malcolmr malcolmr modified the milestone: 1.1.0 Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment