New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week-year based properties fail on calendar-maximal years #197

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015

What steps will reproduce the problem?
1. Create a LocalDate late in the largest year supported by a calendar
2. Ask for the WeekYear

What is the expected output? What do you see instead?
It should give the right year. Instead, it will throw an exception when it 
tries to check whether the date is actually in the next week-year.

Fundamentally we have a problem around maximum/minimum years, as they won't 
necessarily align. We can say we support everything in the last calendar year, 
but we'd potentially need to increase the maximum week-year, and just not 
support everything in that.

(Also, we're not very good at spotting that we've gone outside the bounds of 
the largest year. We should potentially validate against a min/max LocalInstant 
every time we create a new LocalDate/LocalDateTime.)

Original issue reported on code.google.com by jonathan.skeet on 17 Mar 2013 at 10:11

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

This issue was closed by revision 7a65b5f5f560.

Original comment by jonathan.skeet on 18 Mar 2013 at 8:13

  • Changed state: Fixed

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 7a65b5f5f560.

Original comment by jonathan.skeet on 18 Mar 2013 at 8:13

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Original comment by malcolm.rowe on 6 Apr 2013 at 9:08

  • Added labels: Milestone-1.1.0

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 6 Apr 2013 at 9:08

  • Added labels: Milestone-1.1.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment