/nodatime

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IslamicCalendarSystem badly broken #225

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 1 comment

Comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
  1.2.0
2 participants
@GoogleCodeExporter @malcolmr
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015 

Given an Islamic calendar system, this would fail:

    LocalDate date = new LocalDate(1, 3, 1, calendar);
    Assert.AreEqual(1, date.Day);

Basically the whole thing was bust, and I'm amazed that it passed any tests at 
all.

SetYear was broken, too.

These have all been fixed in revision 0fdb944f252b and revision 53b37f241c2c; 
this bug is mostly for version history purposes.

Original issue reported on code.google.com by jonathan.skeet on 11 Jun 2013 at 8:05

@GoogleCodeExporter GoogleCodeExporter added Type-Defect labels Mar 15, 2015

@GoogleCodeExporter GoogleCodeExporter closed this Mar 15, 2015

@GoogleCodeExporter

This comment has been minimized.

Sign in to view

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 26 Jul 2013 at 10:02

  • Added labels: Milestone-1.2.0

@malcolmr malcolmr added the bug label Mar 15, 2015

@malcolmr malcolmr modified the milestone: 1.2.0 Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment