Skip to content

Failure to include "end of year" transitions #335

@GoogleCodeExporter

Description

@GoogleCodeExporter
This is a real corner case, and I think it's already fixed in 2.0, but it means 
we'd be building a broken nzd file into 1.3.1.

Asia/Dakha has two rules for 2009:

Rule    Dhaka   2009    only    -   Jun 19  23:00   1:00    S
Rule    Dhaka   2009    only    -   Dec 31  24:00   0   -

When working out the transitions in Noda Time 1.x, we'd find the local time of 
the first transition after the current interesting instant, and check that the 
year to see if it's in range.

For the "2009 Dec 31st 24:00" transition, the local time is actually Jan 1st 
2010... but that's outside the range of the 2009 rule, if we use the actual 
local time. We should use the "local time before adding the day" instead, I 
think.

Original issue reported on code.google.com by jonathan.skeet on 12 Nov 2014 at 8:30

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions