New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Xamarin.iOS Unified platform #340

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 14 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015

Is it possible to add the xamarinios1 platform to the NuGet NuSpec for the 
current stable release? 
And of course, the later versions. This would be great as we will be able to 
feature this library on the Xamarin Component Store.

The new entry would be:

lib\portable-net4+sl5+netcore45+wpa81+wp8+MonoAndroid1+MonoTouch1+XamariniOS1

I am not sure what I would need to do for this...

Original issue reported on code.google.com by matthew....@xamarin.com on 6 Feb 2015 at 1:26

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

I suppose I could clone the 1.3.x branch and submit a PR? Let me know if this 
would be acceptable.

Original comment by matthew....@xamarin.com on 6 Feb 2015 at 1:26

GoogleCodeExporter commented Mar 15, 2015

I suppose I could clone the 1.3.x branch and submit a PR? Let me know if this 
would be acceptable.

Original comment by matthew....@xamarin.com on 6 Feb 2015 at 1:26

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

The patch: https://code.google.com/p/noda-time/issues/detail?id=341

Original comment by matthew....@xamarin.com on 6 Feb 2015 at 1:30

GoogleCodeExporter commented Mar 15, 2015

The patch: https://code.google.com/p/noda-time/issues/detail?id=341

Original comment by matthew....@xamarin.com on 6 Feb 2015 at 1:30

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

[deleted comment]

GoogleCodeExporter commented Mar 15, 2015

[deleted comment]
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Sure. We were planning on releasing a 1.3.1 with updated time zone support 
soon, so that could support xamarinios1.

Can I check what the difference is between this issue and 341?

Original comment by jonathan.skeet on 6 Feb 2015 at 1:41

GoogleCodeExporter commented Mar 15, 2015

Sure. We were planning on releasing a 1.3.1 with updated time zone support 
soon, so that could support xamarinios1.

Can I check what the difference is between this issue and 341?

Original comment by jonathan.skeet on 6 Feb 2015 at 1:41

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Sorry, my bad. I am not too familiar with the way google code works. I was just 
going to create a patch, but it created an issue as well. :)

Original comment by matthew....@xamarin.com on 6 Feb 2015 at 2:06

GoogleCodeExporter commented Mar 15, 2015

Sorry, my bad. I am not too familiar with the way google code works. I was just 
going to create a patch, but it created an issue as well. :)

Original comment by matthew....@xamarin.com on 6 Feb 2015 at 2:06

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

No problem - I've attached the patch to this issue, and will close the other as 
a duplicate.

Original comment by jonathan.skeet on 6 Feb 2015 at 2:53

Attachments:

GoogleCodeExporter commented Mar 15, 2015

No problem - I've attached the patch to this issue, and will close the other as 
a duplicate.

Original comment by jonathan.skeet on 6 Feb 2015 at 2:53

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Issue 341 has been merged into this issue.

Original comment by jonathan.skeet on 6 Feb 2015 at 2:53

GoogleCodeExporter commented Mar 15, 2015

Issue 341 has been merged into this issue.

Original comment by jonathan.skeet on 6 Feb 2015 at 2:53

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

This issue was closed by revision c65f6c5f172f.

Original comment by jonathan.skeet on 7 Feb 2015 at 4:46

  • Changed state: Fixed

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision c65f6c5f172f.

Original comment by jonathan.skeet on 7 Feb 2015 at 4:46

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

This issue was closed by revision 5e599fd7afdd.

Original comment by jonathan.skeet on 7 Feb 2015 at 4:46

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 5e599fd7afdd.

Original comment by jonathan.skeet on 7 Feb 2015 at 4:46

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Done for both the 2.0 branch and the 1.3 branch.
Will try to get round to doing a 1.3 release in the near future :)

Original comment by jonathan.skeet on 7 Feb 2015 at 4:46

GoogleCodeExporter commented Mar 15, 2015

Done for both the 2.0 branch and the 1.3 branch.
Will try to get round to doing a 1.3 release in the near future :)

Original comment by jonathan.skeet on 7 Feb 2015 at 4:46

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

That is totally awesome! I'll be putting together a package for the Xamarin 
component store

Original comment by mattlei...@live.com on 16 Feb 2015 at 5:39

GoogleCodeExporter commented Mar 15, 2015

That is totally awesome! I'll be putting together a package for the Xamarin 
component store

Original comment by mattlei...@live.com on 16 Feb 2015 at 5:39

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Just to check, do we need to target a different PCL profile for this? We're 
currently using framework v4.0, profile 328.

Original comment by jonsk...@google.com on 18 Feb 2015 at 10:34

GoogleCodeExporter commented Mar 15, 2015

Just to check, do we need to target a different PCL profile for this? We're 
currently using framework v4.0, profile 328.

Original comment by jonsk...@google.com on 18 Feb 2015 at 10:34

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

No.

Profile 328 is fine for both Android and iOS. And probably Mac as well.

Original comment by mattlei...@live.com on 18 Feb 2015 at 1:51

GoogleCodeExporter commented Mar 15, 2015

No.

Profile 328 is fine for both Android and iOS. And probably Mac as well.

Original comment by mattlei...@live.com on 18 Feb 2015 at 1:51

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 15, 2015

Original comment by malcolm.rowe on 19 Feb 2015 at 1:13

  • Added labels: Type-Enhancement, Milestone-1.3.1

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 19 Feb 2015 at 1:13

  • Added labels: Type-Enhancement, Milestone-1.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment