New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in NodaTime.Serialization.JsonNet.nuspec breaks vnext builds (trivial fix!!) #345

Closed
GoogleCodeExporter opened this Issue Mar 15, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@GoogleCodeExporter

GoogleCodeExporter commented Mar 15, 2015

What steps will reproduce the problem?
1. Install the 1.0.0-beta4-11134 vnext runtime
2. Create a project and include NodaTime.Serialization.JsonNet as a dependency
3. Run "kpm restore" on your project.

What is the expected output? What do you see instead?

Expect to be able to build.  Instead see error:

Unable to locate newtonsoft.json >= 4.5.11. Do you mean Newtonsoft.Json?

Please provide any additional information below.

Before recent builds of the k-runtime, this message WAS still emitted, but did 
not seem to break the build system.  Now, however, this prevents the 
project.lock.json file from being written, which breaks the entire build system.

Manually editing the nuspec file to replace "newtonsoft.json" with 
"Newtonsoft.Json" completely eliminates the problem.

I suspect when npm was replaced with kpm, the rules on case matching were 
tightened up, perhaps in anticipation of multi-platform build support.

Original issue reported on code.google.com by cherry...@gmail.com on 25 Feb 2015 at 12:12

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 583cdf362250.

Original comment by jonathan.skeet on 25 Feb 2015 at 6:46

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

This issue was closed by revision 1a181fe4eb09.

Original comment by jonathan.skeet on 25 Feb 2015 at 6:46

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

Thanks very much for spotting this. I've applied it in the 1.3.x and default 
branches; we're hoping to cut a 1.3.1 release in the next week, so it should 
stop being a problem then.

Original comment by jonathan.skeet on 25 Feb 2015 at 6:47

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 27 Feb 2015 at 10:28

  • Added labels: Milestone-1.3.1

@malcolmr malcolmr added the bug label Mar 15, 2015

@malcolmr malcolmr modified the milestone: 1.3.1 Mar 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment