Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization documentation page incorrect? #346

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Closed

Serialization documentation page incorrect? #346

GoogleCodeExporter opened this issue Mar 15, 2015 · 3 comments
Labels
bug
Milestone

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Hi - just looking into the XML serialization formats provided on 
http://nodatime.org/unstable/userguide/serialization.html -

The example local time seems correct:

<value>16:45:20.123456789</value>

But the LocalDateTime, OffsetDateTime, ZonedDateTime all seem to be missing a 
date component:

<value calendar="Gregorian 3">16:45:20.123456789</value>
<value calendar="Gregorian 3">16:45:20.123456789+01:00</value>
<value calendar="Gregorian 3" zone="Europe/London">16:45:20.123456789+01</value>

I could be being a bit slow, but it seems that it is indeed just missing?

Original issue reported on code.google.com by kier...@gmail.com on 26 Feb 2015 at 9:58

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Whoops, you're right. I suspect it's a copy/paste error. Will fix, and then 
check the 1.3 docs.

Original comment by jonathan.skeet on 26 Feb 2015 at 10:04

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Fixed in the 1.2, 1.3 and unstable directories. It'll take a little while to go 
through (as there's probably another build running on the CI machine) but it 
should be done within the next 4 hours...

Original comment by jonathan.skeet on 26 Feb 2015 at 10:10

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Original comment by malcolm.rowe on 27 Feb 2015 at 11:02

  • Added labels: Milestone-1.3.1
@malcolmr malcolmr added the bug label Mar 15, 2015
@malcolmr malcolmr modified the milestone: 1.3.1 Mar 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants