Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTimeZone.UtcId should probably not be public #64

Closed
GoogleCodeExporter opened this issue Mar 15, 2015 · 2 comments
Closed

DateTimeZone.UtcId should probably not be public #64

GoogleCodeExporter opened this issue Mar 15, 2015 · 2 comments
Labels
bug

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

We've defined the UTC timezone ID as "UTC".  It seems odd to provide a public 
constant for that as well, since it's not as if we can change it.

DateTimeZone.UtcId is used by e.g. FixedDateTimeZone, so it should probably be 
retained, but internal (or, better, protected internal, so that someone can 
easily create a 'new' UTC timezone).

Original issue reported on code.google.com by malcolm.rowe on 18 Apr 2012 at 9:34

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Right - will make it internal. If anyone needs it from code they can always get 
it from DateTimeZone.Utc.Id.

Original comment by jonathan.skeet on 18 Apr 2012 at 6:48

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Mar 15, 2015

Fixed in revision 71974e086415.

Original comment by jonathan.skeet on 18 Apr 2012 at 6:55

  • Changed state: Fixed
@malcolmr malcolmr added the bug label Mar 15, 2015
malcolmr pushed a commit that referenced this issue Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants